[coherence-dev] [MERGE/PATCH/REVIEW] nice device type and version helpers
Benjamin Kampmann
ben.kampmann at googlemail.com
Wed Jul 22 00:15:59 CEST 2009
Hi.
As we found out working on the fritz.box during guadec some devices
may not provide a fully correct device-type-string (5 strings
seperated by a ':') all the time. That made the fritzbox media server
not appear in our side. Very stupid. At that certain point we added a
fix by splitting the name in a different way and came accross that we
actually rely on the split-method in a lot of cases. In most cases it
is just for logging/debugging purpose but it could still traceback in
case the device-type-string is slightly missformed. So we came up with
the idea of centralizing the correct lookup code in
core.upnp.device:Device as some more helper methods.
That is what this Review/Merge request is about. I added three more
methods to the DeviceClass and added code for Parsing the data
properly. I also added some of them to the dbus API and did some minor
refactoring and cleanups while replacing the old copy-pasted-code with
the new helper functions. Now only the new helpers are used inside
coherence (also fixed mirabeau).
You can either use the git-branch "nice_device_type" on my github
mirror or you apply these three patches in order of their names (or
use git-am in case you use git).
Thanks for reviewing
Benjamin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-add.patch
Type: application/octet-stream
Size: 5034 bytes
Desc: not available
URL: <http://lists.beebits.net/pipermail/coherence-dev/attachments/20090722/0ba258d3/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-add-helpers-to-dbus-use-helpers-in-base-and-web-ui.patch
Type: application/octet-stream
Size: 6984 bytes
Desc: not available
URL: <http://lists.beebits.net/pipermail/coherence-dev/attachments/20090722/0ba258d3/attachment-0001.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-use-the-new-methods-and-remove-any.patch
Type: application/octet-stream
Size: 8361 bytes
Desc: not available
URL: <http://lists.beebits.net/pipermail/coherence-dev/attachments/20090722/0ba258d3/attachment-0002.obj>
More information about the coherence-dev
mailing list